Skip to content

fix: enforce stack parent invariants and deterministic PR lookup#32

Merged
roodboi merged 1 commit into
mainfrom
fix-stack-validation-holes
Mar 26, 2026
Merged

fix: enforce stack parent invariants and deterministic PR lookup#32
roodboi merged 1 commit into
mainfrom
fix-stack-validation-holes

Conversation

@roodboi

@roodboi roodboi commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • refuse stack create from detached HEAD or an untracked current branch, and refuse stack track --parent when the parent is not trunk or already tracked
  • make FindPRByHead ignore historical closed or merged matches and fail on ambiguous multiple open PRs instead of silently choosing one
  • document that stack queue depends on GitHub repository auto-merge because the command delegates the final handoff through gh pr merge --auto

Verification

  • mise exec -- go test ./...
  • mise exec -- go build ./...
  • scripts/sandbox/run-live-queue.sh under roodboi after enabling repo auto-merge; queue handoff succeeded and GitHub left the sandbox PR open as BLOCKED until normal repo gating clears

Linear

  • HACK-613
  • HACK-614

@roodboi roodboi enabled auto-merge March 26, 2026 01:37
@roodboi roodboi disabled auto-merge March 26, 2026 01:37
@roodboi roodboi merged commit c823ef7 into main Mar 26, 2026
3 checks passed
@roodboi roodboi deleted the fix-stack-validation-holes branch March 26, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant